chore(travis): fix packagelock for node v8 #894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI was broken because the npm which ships with node v8 (and only that version of npm, for some reason), would modify package-lock.json when we ran `npm install`. This triggered our post-test hook which enforces docs changes: the modified file was detected as a false-positive for uncommitted docs changes. This fixes the issue by committing those docs changes. This seems to be compatible with other npm versions. Fixes #893
|
Unfortunately, this wasn't the righht fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was broken because the npm which ships with node v8 (and only that
version of npm, for some reason), would modify package-lock.json when we
ran
npm install. This triggered our post-test hook which enforces docschanges: the modified file was detected as a false-positive for
uncommitted docs changes.
This fixes the issue by committing those docs changes. This seems to be
compatible with other npm versions.
Fixes #893