Report forgotten errors from 'mv' #879
Conversation
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 34 34
Lines 1266 1266
=======================================
Hits 1213 1213
Misses 53 53
Continue to review full report at Codecov.
|
| @@ -110,6 +110,8 @@ function _mv(options, sources, dest) { | |||
| // exception to pass up to the top level. | |||
| cp('-r', src, thisDest); | |||
| rm('-rf', src); | |||
| } else { | |||
| common.error(e.message, { continue: true }); | |||
There was a problem hiding this comment.
Could you catch a specific e.code and output a message like mv: cannot move 'foo/a/file.js' to 'bar/a/file.js': No such file or directory?
Also, could you add an else branch with throw e? The distinction is that we only want to use common.error() for expected error conditions, and would prefer to fail loudly with an exception for unexpected conditions (so that we can fix these as they're reported).
nfischer
added
fix
|
@vgalka-sl any update on this issue? Let me know if I can clarify anything. |
Fix for issue #878.