Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mocks): fix conflict between mocks and skip #863

Merged
merged 1 commit into from Jun 28, 2018
Merged

fix(mocks): fix conflict between mocks and skip #863

merged 1 commit into from Jun 28, 2018

Commits on Jun 25, 2018

  1. fix(mocks): fix conflict between mocks and skip 

    This fixes a conflict between mocks.init() and
utils.skipOnWin/skipOnUnix. mocks.init() mocks out process.stderr.write,
which utils.js implicitly depends on.

Instead, preserve stderr.write in a local variable to avoid polluting
mocked stdio and to correctly output warning messages.

Fixes #862
Test: locally apply mocks.init() inside test/which.js
    @nfischer
    nfischer committed Jun 25, 2018
    Copy the full SHA
    df4dfab View commit details
    Browse the repository at this point in the history