New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(appveyor): do not use latest npm #847
Conversation
This changes appveyor from using the latest npm version to only using the preinstalled npm version. This is safer, because it's guaranteed to be a compatible version. Fixes #844
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
======================================
Coverage 95.8% 95.8%
======================================
Files 34 34
Lines 1262 1262
======================================
Hits 1209 1209
Misses 53 53 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm landing this, because we need to fix master ASAP. However, there's a caveat to this change: npm recommends npm@3 on Windows, however this change bumps the node4 bot down to npm@2.15.11. It's not clear if this causes correctness issues. This may merit further investigation. |
This changes appveyor from using the latest npm version to only using
the preinstalled npm version. This is safer, because it's guaranteed to
be a compatible version.
Fixes #844