Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appveyor): do not use latest npm #847

Merged
merged 1 commit into from May 10, 2018
Merged

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented May 9, 2018

This changes appveyor from using the latest npm version to only using
the preinstalled npm version. This is safer, because it's guaranteed to
be a compatible version.

Fixes #844

This changes appveyor from using the latest npm version to only using
the preinstalled npm version. This is safer, because it's guaranteed to
be a compatible version.

Fixes #844
@codecov-io
Copy link

codecov-io commented May 9, 2018

Codecov Report

Merging #847 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #847   +/-   ##
======================================
  Coverage    95.8%   95.8%           
======================================
  Files          34      34           
  Lines        1262    1262           
======================================
  Hits         1209    1209           
  Misses         53      53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a4df8...6542ebd. Read the comment docs.

Copy link
Contributor

@freitagbr freitagbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nfischer
Copy link
Member Author

I'm landing this, because we need to fix master ASAP. However, there's a caveat to this change: npm recommends npm@3 on Windows, however this change bumps the node4 bot down to npm@2.15.11.

It's not clear if this causes correctness issues. This may merit further investigation.

@nfischer nfischer merged commit 4733a32 into master May 10, 2018
@nfischer nfischer deleted the chore-appveyor-npm-version branch May 10, 2018 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants