Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: copy recursively from read only location. (fixes #98) #555

Closed
wants to merge 1 commit into from
Closed

Fix: copy recursively from read only location. (fixes #98) #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 25 additions & 0 deletions ava-test/cp.js
View file
Open in desktop
Expand Up @@ -647,3 +647,28 @@ test('Test with recursive option and symlinks.', t => {
t.falsy(shell.test('-L', 'sym.lnk'));
});
});


// cp -R should be able to copy a readonly src (issue #98).
// On Windows, chmod acts VERY differently so skip these tests for now
test('cp -R should be able to copy a readonly src. issue #98; (Non window platforms only)', t => {
if (common.platform !== 'win') {
shell.cp('-r', 'resources/cp', t.context.tmp);
shell.chmod('555', `${t.context.tmp}/cp/`);
shell.chmod('555', `${t.context.tmp}/cp/dir_a`);
shell.chmod('555', `${t.context.tmp}/cp/dir_b`);
shell.chmod('555', `${t.context.tmp}/cp/a`);

const result = shell.cp('-r', `${t.context.tmp}/cp`, `${t.context.tmp}/cp_cp`);
t.falsy(shell.error());
t.falsy(result.stderr);
t.is(result.code, 0);

t.is(shell.ls('-R', `${t.context.tmp}/cp`) + '', shell.ls('-R', `${t.context.tmp}/cp_cp`) + '');
t.is(fs.statSync(`${t.context.tmp}/cp_cp`).mode & parseInt('777', 8), parseInt('555', 8));
t.is(fs.statSync(`${t.context.tmp}/cp_cp/dir_a`).mode & parseInt('777', 8), parseInt('555', 8));
t.is(fs.statSync(`${t.context.tmp}/cp_cp/a`).mode & parseInt('777', 8), parseInt('555', 8));

shell.chmod('-R', '755', t.context.tmp);
}
});
7 changes: 5 additions & 2 deletions src/cp.js
View file
Open in desktop
Expand Up @@ -94,8 +94,7 @@ function cpdirSyncRecursive(sourceDir, destDir, currentDepth, opts) {
// Create the directory where all our junk is moving to; read the mode of the
// source directory and mirror it
try {
var checkDir = fs.statSync(sourceDir);
fs.mkdirSync(destDir, checkDir.mode);
fs.mkdirSync(destDir);
} catch (e) {
// if the directory already exists, that's okay
if (e.code !== 'EEXIST') throw e;
Expand Down Expand Up @@ -146,6 +145,10 @@ function cpdirSyncRecursive(sourceDir, destDir, currentDepth, opts) {
}
}
} // for files

// finally change the mode for the newly created directory.
var checkDir = fs.statSync(sourceDir);
fs.chmod(destDir, checkDir.mode);
} // cpdirSyncRecursive

function cpcheckcycle(sourceDir, srcFile) {
Expand Down