Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array of commands in exec #152

Closed
wants to merge 2 commits into from
Closed

Add array of commands in exec #152

wants to merge 2 commits into from

Conversation

isRuslan
Copy link

Hi everyone.
I suggest to add possibility to set array of commands in first argument of exec method.
Example:

shell.exec(['git pull', 'npm i'], function(code, output) {

});

Fixes #103

@isRuslan
Copy link
Author

👀

@ariporad
Copy link
Contributor

@nfischer: What are your thoughts? I'm not so sure about this.

@nfischer
Copy link
Member

I vote to close this. I think Array.join(';') is good enough for most users

@ariporad
Copy link
Contributor

Me too. Closing.

@ariporad ariporad closed this Jan 25, 2016
@ariporad
Copy link
Contributor

@isRuslan: Thanks so much for your PR, but unfortunately we're going to have to close this. It's just a very strange use-case, and [command1, command2, ...commandN].join(';') should really work for most cases. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple string arguments for exec()
3 participants