test: make a test more forgiving for systems with non-standard bash and sh paths #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding a [`w` flag to the write call](nodejs/node#50989). Also made a test more forgiving so it passes on systems that have non-standard `bash` and `sh` binary paths.
|
I think the I'm happy to accept the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1144 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 36 36
Lines 1360 1360
=======================================
Hits 1323 1323
Misses 37 37 ☔ View full report in Codecov by Sentry. |
|
Yep, looks like |
Node regression fixed by `21.4`
nfischer
changed the title
nfischer
approved these changes
Dec 7, 2023
|
Thanks for the fix! I updated the PR title and description since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: make a test more forgiving for systems with non-standard bash and sh paths
Edit from @nfischer: this was originally to address #1143, however it appears that bug was fixed in Node.js 21.4 instead. Original PR description below:
By adding a
wflag to the write call. Also made a test more forgiving so it passes on systems that have non-standardbashandshbinary paths.This fixes #1143 .