Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix test coverage parsing bug #1131

Closed
wants to merge 1 commit into from
Closed

chore: fix test coverage parsing bug #1131

wants to merge 1 commit into from

Commits on Aug 28, 2023

  1. chore: fix test coverage parsing bug 

    For some reason it seems like `nyc` v14 is incompatible with node
v16/v18/v20. See this CI run as an example:
https://github.com/shelljs/shelljs/actions/runs/5956710281/job/16287478757?pr=1129

This updates `nyc` to v15 which should fix the issue.

Fixes #1130
Test: nvm use v16.20.2
Test: npm run test-with-coverage
    @nfischer
    nfischer committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    280791d View commit details
    Browse the repository at this point in the history