[cp] Add test for cycle symlink #1045
Conversation
| @@ -621,26 +621,20 @@ test('Test max depth.', t => { | |||
| // Check last directory to exist is below maxdepth. | |||
| t.truthy(shell.test('-d', `${t.context.tmp}/copytestdepth${directory32deep}`)); | |||
| t.falsy(shell.test('-d', `${t.context.tmp}/copytestdepth${directory32deep}/32`)); | |||
| utils.skipOnWinForEPERM(shell.ln.bind(shell, '-s', `${t.context.tmp}/0`, `${t.context.tmp}/symlinktest`), () => { | |||
There was a problem hiding this comment.
Delete it because it doesn't create symlinks to check for cycle.
|
test passes in my local environment... 😓 |
|
Could you rebase? I recently updated CI to use GitHub actions instead. This may be more reliable than the old environment. |
Codecov Report
@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
- Coverage 97.19% 97.04% -0.15%
==========================================
Files 36 36
Lines 1354 1354
==========================================
- Hits 1316 1314 -2
- Misses 38 40 +2
Continue to review full report at Codecov.
|
|
I don't know how to solve this problem in windows, so close |
|
Thanks for trying the rebase. Looks like the error message from https://github.com/shelljs/shelljs/runs/5018531671?check_suite_focus=true is: I wonder if |
|
|
Related: #739