Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release to fix Node.js 14 warnings #991

Closed
gengjiawen opened this issue Apr 22, 2020 · 4 comments
Closed

New release to fix Node.js 14 warnings #991

gengjiawen opened this issue Apr 22, 2020 · 4 comments
Labels
fix Bug/defect, or a fix for such a problem high priority
Milestone

Comments

@gengjiawen
Copy link

Fixed in 05374a7.

Current warning

(node:32597) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:814:11)
    at Object.get (internal/modules/cjs/loader.js:825:5)
    at Object._register [as register] (/Users/daniel/code/quickapp-demo/node_modules/shelljs/src/common.js:453:12)
    at Object.<anonymous> (/Users/daniel/code/quickapp-demo/node_modules/shelljs/src/cat.js:4:8)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
    at Function.Module._load (internal/modules/cjs/loader.js:923:14)
    at Module.require (internal/modules/cjs/loader.js:1074:19)
    at require (internal/modules/cjs/helpers.js:72:18)
@Unitech
Copy link

Unitech commented Apr 22, 2020

When do you think it will be published?
It's throwing a bunch of warnings on pm2 update procedure:

unitech@zion:~/keymetrics/pm2-runtime/pm2$ pm2 update
Be sure to have the latest version by doing `npm install pm2@latest -g` before doing this procedure.
[PM2] [v] Modules Stopped
[PM2] Applying action deleteProcessId on app [all](ids: [
   0,  1,  2,  3,  4,  5,  6,
   7,  8,  9, 10, 11, 12, 13,
  14, 15, 16, 17, 18, 19
])
[PM2] [http](6) ✓
[PM2] [http](5) ✓
[PM2] [http](4) ✓
[PM2] [http](3) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] Agent Stopped
[PM2] [v] PM2 Daemon Stopped
[PM2] Spawning PM2 daemon with pm2_home=/home/unitech/.pm2
(node:30924) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:30924) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
(node:30924) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
[PM2] Restoring processes located in /home/unitech/.pm2/dump.pm2
[PM2] Process /home/unitech/keymetrics/pm2-runtime/pm2/examples/cluster-http/http.js restored
[PM2] Process /home/unitech/keymetrics/pm2-runtime/pm2/examples/cluster-http/http.js restored
[PM2] Process /home/unitech/keymetrics/pm2-runtime/pm2/examples/cluster-http/http.js restored
[PM2] Process /home/unitech/keymetrics/pm2-runtime/pm2/examples/cluster-http/http.js restored

@nfischer
Copy link
Member

Thanks for raising this to my attention. I'll take a look and see if I can spin up a patch release.

@nfischer nfischer added fix Bug/defect, or a fix for such a problem high priority labels Apr 23, 2020
@Stono
Copy link

Stono commented Apr 23, 2020

Just adding my +1 to this, a lot of our child dependencies seem to use this module so its blocking many upgrades! Thanks for your efforts fixing it

@nfischer
Copy link
Member

This should be released as v0.8.4 :shipit: 🎉 This only differs from v0.8.3 by pulling in the referenced change.

2 tests fail on the 0.8-release branch, but I'm not concerned:

  • exec › set maxBuffer (very small) - This was a node v10 change (see exec() should support node v10 (maxbuffer change) #915), and I don't think we need to backport the workaround
  • exec › command that fails - This test uses shx@0.2.2, which pulls in its own copy of shelljs@v0.7.8. So this is just a test issue.

AndrewKvalheim added a commit to AndrewKvalheim/git-rev-sync-js that referenced this issue May 15, 2020
Resolves warnings (shelljs/shelljs#991):

    $ node --version
    v14.1.0
    $ npm run test

    > git-rev-sync@2.0.0 test /home/ak/src/git-rev-sync-js
    > node tests/index

    tests passed
    (node:143612) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
AndrewKvalheim added a commit to AndrewKvalheim/git-rev-sync-js that referenced this issue May 15, 2020
Resolves warnings (shelljs/shelljs#991):

    $ node --version
    v14.1.0
    $ npm run test

    > git-rev-sync@2.0.0 test /home/ak/src/git-rev-sync-js
    > node tests/index

    tests passed
    (node:143612) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
AndrewKvalheim added a commit to AndrewKvalheim/git-rev-sync-js that referenced this issue May 15, 2020
Resolves warnings (shelljs/shelljs#991):

    $ node --version
    v14.1.0
    $ npm run test

    > git-rev-sync@2.0.0 test ~/src/git-rev-sync-js
    > node tests/index

    tests passed
    (node:143612) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
    (node:143612) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
timarandras added a commit to timarandras/git-rev-sync-js that referenced this issue Jul 1, 2020
Needed to eliminate warnings on Node v14. See shelljs/shelljs#991.
@nfischer nfischer added this to the v0.8.4 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug/defect, or a fix for such a problem high priority
Projects
None yet
Development

No branches or pull requests

4 participants