New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release to fix Node.js 14 warnings #991
Comments
When do you think it will be published?
|
Thanks for raising this to my attention. I'll take a look and see if I can spin up a patch release. |
Just adding my +1 to this, a lot of our child dependencies seem to use this module so its blocking many upgrades! Thanks for your efforts fixing it |
This should be released as v0.8.4 🎉 This only differs from v0.8.3 by pulling in the referenced change. 2 tests fail on the
|
Resolves warnings (shelljs/shelljs#991): $ node --version v14.1.0 $ npm run test > git-rev-sync@2.0.0 test /home/ak/src/git-rev-sync-js > node tests/index tests passed (node:143612) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'find' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'head' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'set' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'test' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'to' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
Resolves warnings (shelljs/shelljs#991): $ node --version v14.1.0 $ npm run test > git-rev-sync@2.0.0 test /home/ak/src/git-rev-sync-js > node tests/index tests passed (node:143612) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'find' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'head' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'set' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'test' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'to' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
Resolves warnings (shelljs/shelljs#991): $ node --version v14.1.0 $ npm run test > git-rev-sync@2.0.0 test ~/src/git-rev-sync-js > node tests/index tests passed (node:143612) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'find' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'head' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'set' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'test' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'to' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
Needed to eliminate warnings on Node v14. See shelljs/shelljs#991.
Fixed in 05374a7.
Current warning
The text was updated successfully, but these errors were encountered: