Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 14 Circular dependency error due to ShellJS #12793

Closed
clementprevot opened this issue Oct 16, 2020 · 1 comment
Closed

Node 14 Circular dependency error due to ShellJS #12793

clementprevot opened this issue Oct 16, 2020 · 1 comment

Comments

@clementprevot
Copy link
Contributor

This is a reopening of #11173

Describe the bug

When running Storybook with Node 14, there are a lot of "Circular dependencies" error thrown (that doesn't affect the proper working of Storybook though):

image

When running with --trace-warning here is the result:

image

So clearly the issue is coming from ShellJS.
And indeed, there are some issues over there talking about that.

And the solution is simple: update to ShellJS 0.8.4.

AFAIK, @storybook/root is using 0.8.4, but not @storybook/core.

The last message of the previous issue suggested to create a PR to upgrade the package but I think that nobody did it.

So I'm reopening this issue and will issue a PR to solve it.

@shilman
Copy link
Member

shilman commented Oct 18, 2020

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.0-alpha.26 containing PR #12794 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants