Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shx as a dependency for testing #525

Closed
nfischer opened this issue Oct 9, 2016 · 4 comments
Closed

Add shx as a dependency for testing #525

nfischer opened this issue Oct 9, 2016 · 4 comments
Labels
exec Issues specific to the shell.exec() API medium priority test

Comments

@nfischer
Copy link
Member

nfischer commented Oct 9, 2016

Tests in #524 are breaking because there's no good way to test the cwd option. There are also other parts where we try to use grep, but can't use it if it doesn't exist on Windows. If we import shx as a dev dependency, then we can get away with using shx pwd and shx grep for these tests.

@nfischer
Copy link
Member Author

Also, just realized that shx only supports v4+. I think the best thing is to just expand it with polyfills where necessary to support v0.11+. This might be a bit of work, but it should be achievable.

@nfischer
Copy link
Member Author

shx now has the proper support. We need to fix some of the remaining shx issues and then make a new release. Once ShellJS depends on that release, we can close this.

@nfischer
Copy link
Member Author

nfischer commented Nov 8, 2016

shx 0.2.0 has been released, so this is no longer blocked.

@nfischer
Copy link
Member Author

nfischer commented Nov 9, 2016

Fixed by #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exec Issues specific to the shell.exec() API medium priority test
Projects
None yet
Development

No branches or pull requests

1 participant