chore(node): add v10 and v11 to CI (#921)

This adds support for v10 and v11, and removes a TODO.
shelljs · Dec 3, 2018 · 355287e · 355287e
1 parent 5cab915
commit 355287e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,8 @@ node_js:
   - 7
   - 8
   - 9
+  - 10
+  - 11
 
 os:
   - linux

diff --git a/appveyor.yml b/appveyor.yml
@@ -1,5 +1,7 @@
 environment:
   matrix:
+    - nodejs_version: '11'
+    - nodejs_version: '10'
     - nodejs_version: '9'
     - nodejs_version: '8'
     - nodejs_version: '7'

diff --git a/scripts/check-node-support.js b/scripts/check-node-support.js
@@ -9,7 +9,7 @@ var shell = require('..');
 
 // This is the authoritative list of supported node versions.
 var MIN_NODE_VERSION = 6;
-var MAX_NODE_VERSION = 9;
+var MAX_NODE_VERSION = 11;
 
 function checkReadme(minNodeVersion) {
   var start = '<!-- start minVersion -->';

diff --git a/src/exec-child.js b/src/exec-child.js
@@ -28,8 +28,6 @@ function isMaxBufferError(err) {
     // >= v10
     // RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length
     // exceeded
-    // TODO(nfischer): remove when we add v10 CI (Github issue #856).
-    /* istanbul ignore next */
     return true;
   }
   return false;