fix fabric8io#4408: deprecating addSharedInformerEventListener

CHANGELOG.md

@@ -35,6 +35,7 @@
 * Module `io.fabric8:tekton-model-triggers` which contained Tekton triggers v1alpha1 model has been removed. We have introduced separate modules `io.fabric8:tekton-model-v1alpha1` and `io.fabric8:tekton-model-v1beta1` for Tekton triggers v1alpha1 and v1beta1 apigroups respectively. Users who are using `io.fabric8:tekton-client` dependency directly should be unaffected by this change.
 * Fix #4384: javax.validation.* annotations are no longer added by the Java generator.
 * Fix #3864: Now it's compulsory to provide `etc/io.fabric8.openshift.client.cfg` file in order to load ManagedOpenShiftClient in OSGi environment.
+* Fix #4408: deprecated SharedInformerFactory.addSharedInformerEventListener, instead use the SharedIndexInformer.stopped method.  Also the signature of SharedIndexInformer.start was changed to a CompletionStage rather than a CompletableFuture.
 
 ### 5.12.4 (2022-09-30)
 

kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/informers/SharedIndexInformer.java

@@ -175,7 +175,7 @@ default boolean hasSynced() {
 
   /**
    * Sets the {@link ExceptionHandler} for this informer. For example, exceptionHandler((b, t) -> true)), will
-   * keep retying no matter what the exception is.
+   * keep retrying no matter what the exception is.
    * <p>
    * May only be called prior to the informer starting
    *

kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/informers/SharedInformerFactory.java

@@ -81,6 +81,10 @@ <T extends HasMetadata> SharedIndexInformer<T> sharedIndexInformerFor(Class<T> a
    */
   void stopAllRegisteredInformers();
 
+  /**
+   * @deprecated use {@link SharedIndexInformer#stopped()} method to get notified when an informer stops.
+   */
+  @Deprecated
   void addSharedInformerEventListener(SharedInformerEventListener event);
 
 }

kubernetes-examples/src/main/java/io/fabric8/kubernetes/examples/CustomResourceInformerExample.java

@@ -56,8 +56,11 @@ public void onDelete(Dummy pod, boolean deletedFinalStateUnknown) {
             }
           });
 
-      sharedInformerFactory
-          .addSharedInformerEventListener(ex -> logger.error("Exception occurred, but caught: {}", ex.getMessage()));
+      podInformer.stopped().whenComplete((v, t) -> {
+        if (t != null) {
+          logger.error("Exception occurred, caught: {}", t.getMessage());
+        }
+      });
 
       logger.info("Starting all registered informers");
       sharedInformerFactory.startAllRegisteredInformers();