Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'publish' script if it's 'clean-publish' #135

Merged
merged 2 commits into from Dec 4, 2021
Merged

Remove 'publish' script if it's 'clean-publish' #135

merged 2 commits into from Dec 4, 2021

Commits on Dec 4, 2021

  1. Remove 'publish' script if it's 'clean-publish' 

    If someone would try setting up 'clean-publish' as told in the docs,
one would get an endless loop when trying to call 'npm publish'. This
is because 'publish' scripts were not removed but called after cleanup,
which would then cause the program to loop endlessly and creates an
infinite tree of temporary directories.

After this commit, 'clean-publish' will check if the 'publish' script
contains call to 'clean-publish' and, if that's the case, remove this
script.

Closes #134
    @kytta
    kytta committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    abe0eac View commit details
    Browse the repository at this point in the history

  2. Do a safer check 

    Check if the script is *exactly* 'clean-publish' or starts with
'clean-publish ' (= is a clean-publish call with arguments)
    @kytta
    kytta committed Dec 4, 2021
    Configuration menu
    Copy the full SHA
    ea410bb View commit details
    Browse the repository at this point in the history