Remove 'publish' script if it's 'clean-publish' #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone would try setting up 'clean-publish' as told in the docs, one would get an endless loop when trying to call 'npm publish'. This is because 'publish' scripts were not removed but called after cleanup, which would then cause the program to loop endlessly and creates an infinite tree of temporary directories. After this commit, 'clean-publish' will check if the 'publish' script contains call to 'clean-publish' and, if that's the case, remove this script. Closes #134
ai
reviewed
Dec 4, 2021
Check if the script is *exactly* 'clean-publish' or starts with 'clean-publish ' (= is a clean-publish call with arguments)
|
Thanks. Released in 3.4.4. |
ai
added a commit
that referenced
this pull request
Jan 19, 2022
Remove 'publish' script if it's 'clean-publish'
ai
added a commit
that referenced
this pull request
Jan 19, 2022
Remove 'publish' script if it's 'clean-publish'
ai
added a commit
that referenced
this pull request
Jan 19, 2022
Remove 'publish' script if it's 'clean-publish'
ai
added a commit
that referenced
this pull request
Apr 11, 2023
Remove 'publish' script if it's 'clean-publish'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone would try setting up 'clean-publish' as told in the docs,
one would get an endless loop when trying to call 'npm publish'. This
is because 'publish' scripts were not removed but called after cleanup,
which would then cause the program to loop endlessly and creates an
infinite tree of temporary directories.
After this commit, 'clean-publish' will check if the 'publish' script
contains call to 'clean-publish' and, if that's the case, remove this
script.
Closes #134