New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds publishing check and makes Sharpliner self-hosted #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename Sharpliner.Model to Sharpliner - Remove tests projects to match projects
Conflicts: Sharpliner.sln src/Sharpliner/PipelineDefinitionBase.cs
# Conflicts: # azure-pipelines.yml # eng/Sharpliner.CI/SharplinerPipeline.cs # src/Sharpliner/AzureDevOps/AzureDevOpsPipelineDefinition.cs
premun
changed the title
Adds publish check and makes Sharpliner self-hosted
Adds publishing check and makes Sharpliner self-hosted
May 12, 2021
@mandel-macaque I changed YAML and named one stage "Build and test 2", the number 2 is not in the C# definition of the pipeline -> the build fails :) So we will have the build check whether we committed all of the changes always |
mandel-macaque
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the project use the pipeline defined using Sharpliner inside the
Sharpliner.CI
project!Adds an AzDO task that will verify whether you have published and commited all changes into YAML files. (resolves #3)
The many empty arrays in the YAML will be gone once we check in aaubry/YamlDotNet#608