Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clap derive #1067

Merged
merged 28 commits into from
Nov 1, 2022
Merged

Clap derive #1067

merged 28 commits into from
Nov 1, 2022

Commits on Sep 9, 2022

  1. Upgrade clap to 3.2

    @tmccombs
    tmccombs committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    6655356 View commit details
    Browse the repository at this point in the history

  2. Bump MSRV to 1.56.1 

    Because that is what is needed by clap 2
    @tmccombs
    tmccombs committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    45d6f55 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Use clap-derive for option parsing 

    This makes the definition of arguments to fd a little more ergonomic,
and makes it easier to insure the types for the arguments are consitent.
    @tmccombs
    tmccombs committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    4e7b403 View commit details
    Browse the repository at this point in the history

  2. Improve help output after switch to clap-derive 

    Make it more like it used to be.
    @tmccombs
    tmccombs committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    b7f5f4a View commit details
    Browse the repository at this point in the history

  3. Fix case of color options to ls

    @tmccombs
    tmccombs committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    066ce41 View commit details
    Browse the repository at this point in the history

  4. Fix clippy warnings

    @tmccombs
    tmccombs committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    e6f4805 View commit details
    Browse the repository at this point in the history

  5. clap derive suggestions from epage

    @tmccombs
    tmccombs committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    ff7336b View commit details
    Browse the repository at this point in the history

  6. Add action clap attribute to fixed_strings

    @tmccombs
    tmccombs committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    a50e417 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Upgrade to clap 4.0

    @tmccombs
    tmccombs committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    f4c34b8 View commit details
    Browse the repository at this point in the history

  2. Support powershell when guessing shell for completions

    @tmccombs
    tmccombs committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    5b9e302 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into clap-derive

    @tmccombs
    tmccombs committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    c41d61e View commit details
    Browse the repository at this point in the history

  4. Fix name of powershell in guess_shell

    @tmccombs
    tmccombs committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    86c3349 View commit details
    Browse the repository at this point in the history

  5. Actually test if exec or exec-batch is used 

    By the time we check if we should strip the cwd, we've already moved the
command out of the options, so store if we got that out earlier.
    @tmccombs
    tmccombs committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    aca64c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Fix typo in test

    @tmccombs
    tmccombs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    10ecb64 View commit details
    Browse the repository at this point in the history

  2. Update clap depenency version

    @tmccombs
    tmccombs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    bf1a6f6 View commit details
    Browse the repository at this point in the history

  3. Update msrv to 1.60 

    Because that is what clap requires
    @tmccombs
    tmccombs committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    c0b1470 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Fix deprecations from clap 4.0

    @tmccombs
    tmccombs committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c211588 View commit details
    Browse the repository at this point in the history

  2. Change thread option to take u32 instead of usize 

    To simplify the option parsing.
    @tmccombs
    tmccombs committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b6f0088 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Fix format

    @tmccombs
    tmccombs committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    aec1256 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Remove TODO comment 

    In favor of tracking scoped threads in sharkdp#1141
    @tmccombs
    tmccombs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a3622ba View commit details
    Browse the repository at this point in the history

  2. Improve help output

    @tmccombs
    tmccombs committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3782278 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Merge remote-tracking branch 'upstream/master' into clap-derive

    @tmccombs
    tmccombs committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8500c31 View commit details
    Browse the repository at this point in the history

  2. Make help output more like what it was before use clap_derive 

    In particular, we specifically use `long_help` instead of doc comments
because using  doc comments will always trim the "." off the end of the
first paragraph, and will include the short help as the first paragraph
of the full help.
    @tmccombs
    tmccombs committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    36ee44a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into clap-derive

    @sharkdp
    sharkdp committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    169d22f View commit details
    Browse the repository at this point in the history

  4. Remove outdated TODO comment

    @sharkdp
    sharkdp committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3f72ef4 View commit details
    Browse the repository at this point in the history

  5. Fix unit tests

    @sharkdp
    sharkdp committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ebd48d4 View commit details
    Browse the repository at this point in the history

  6. Minor: add missing full stop

    @sharkdp
    sharkdp committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    55029e8 View commit details
    Browse the repository at this point in the history

  7. Add newlines between options

    @sharkdp
    sharkdp committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    5771e74 View commit details
    Browse the repository at this point in the history