Enable jemallocator on 64-bit musl builds #1062
Conversation
|
I think the reason why I disabled them for musl builds back then (#481) was purely based on the fact that jemalloc didn't work in combination with musl. If there is no other reason we can think of (unfortunately, there is not more information in my commit messages / PR description and the Travis logs are not available anymore), this sounds like a good idea - thank you! |
|
Whoops I force pushed |
tavianator
force-pushed
the
musl-jemalloc
branch
from
9bea057
to
b1c3468
Compare
|
So actually this used to work, but right now the musl version bundled with Rust is too old, leading to tikv/jemallocator#30 tikv/pprof-rs#142 |
Done. No worries. |
|
Actually CI works for x86-64, it's just broken on my computers. Can be worked around with The i686 failure might be related to rust-lang/cc-rs#436. |
|
How do we want to proceed here? I think it would be great to get this into the next release. Maybe we can just add a special case for the two platforms that are failing (i.e.: disable jemalloc for those) and add a comment that links to the tickets you mentioned above? That would still give musl+jemalloc on the more important platforms. |
|
@sharkdp That sounds good to me! I probably won't have time for a few days so feel free to take this over if you do. |
Partial fix for sharkdp#710 and sharkdp#980.
tavianator
force-pushed
the
musl-jemalloc
branch
from
b1c3468
to
bc438f4
Compare
tavianator
changed the title
tavianator
force-pushed
the
musl-jemalloc
branch
3 times, most recently
from
6b29b68
to
bc438f4
Compare
|
The remaining two cases are 32-bit arm and x86. I got x86 working in debug builds but release builds still fail to link. I think x86 may be fixed in a future Rust release by upgrading |
Partial fix for #710 and #980.