Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MATLAB syntax test file #1337

Merged
merged 1 commit into from Oct 24, 2020

Conversation

senden9
Copy link
Contributor

@senden9 senden9 commented Oct 24, 2020

I used a modified version of the pygments test file here. As noted in the license file. Syntax highlighting looks correct. I have checked the created highlighted file. We also have quite some syntax here that is tested with that test.

The modification I made was to use block comments like they are in the official matlab documentation under https://www.mathworks.com/help/matlab/matlab_prog/comments.html

To comment out multiple lines of code, use the block comment operators, %{ and %}. The %{ and %} operators must appear alone on the lines that immediately precede and follow the block of help text. Do not include any other text on these lines.

cc #1213

@senden9
Copy link
Contributor Author

senden9 commented Oct 24, 2020

I opened an issue in the pygments repo for that change. Cross reference: pygments/pygments#1582

@senden9
Copy link
Contributor Author

senden9 commented Oct 24, 2020

Also the syntax highlighting is not 100% correct currently. I opened an issue upstream for that. Cross reference: sublimehq/Packages#2561

@sharkdp
Copy link
Owner

sharkdp commented Oct 24, 2020

Thank you very much for your contribution and for the other (upstream) issues/PRs!

@sharkdp sharkdp merged commit be84682 into sharkdp:master Oct 24, 2020
@senden9
Copy link
Contributor Author

senden9 commented Nov 12, 2020

Hi @sharkdp !
is it possible that you add the label hacktoberfest-accepted to this PR, #1336, and/or #1338? As far as I see this repository has the hacktoberfest tag on it. But my PRs do not count anyway.

I get this message for that three pull requests:

Ineligible Repository
Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

If you don't want to add its of course also fine :D

@sharkdp
Copy link
Owner

sharkdp commented Nov 12, 2020

As far as I see this repository has the hacktoberfest tag on it. But my PRs do not count anyway.

hm... :-/

is it possible that you add the label hacktoberfest-accepted

done.

@senden9
Copy link
Contributor Author

senden9 commented Nov 12, 2020

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants