add test for ansi highlight underline, fix underscore in plain

sharkdp · Feb 7, 2022 · 57adeac · 57adeac
1 parent 0bbdddf
commit 57adeac
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/printer.rs b/src/printer.rs
@@ -655,6 +655,7 @@ impl<'a> Printer for InteractivePrinter<'a> {
 
         if highlight_this_line && self.config.theme == "ansi" {
             self.ansi_style.update("^[24m");
+            write!(handle, "\x1B[24m")?;
         }
 
         Ok(())

diff --git a/tests/integration_tests.rs b/tests/integration_tests.rs
@@ -1290,6 +1290,25 @@ fn grid_for_file_without_newline() {
         .stderr("");
 }
 
+// For ANSI theme, use underscore as a highlighter
+#[test]
+fn ansi_highlight_underline() {
+    bat()
+        .arg("--paging=never")
+        .arg("--color=never")
+        .arg("--terminal-width=80")
+        .arg("--wrap=never")
+        .arg("--decorations=always")
+        .arg("--theme=ansi")
+        .arg("--style=plain")
+        .arg("--highlight-line=1")
+        .write_stdin("Ansi Underscore Test\nAnother Line")
+        .assert()
+        .success()
+        .stdout("\x1B[4mAnsi Underscore Test\n\x1B[24mAnother Line")
+        .stderr("");
+}
+
 // Ensure that ANSI passthrough is emitted properly for both wrapping and non-wrapping printer.
 #[test]
 fn ansi_passthrough_emit() {