fix: make Message#author lazy #204
Conversation
| member = @channel.server.member(data['author']['id'].to_i) | ||
|
|
||
| if member | ||
| member.update_data(data['member']) if data['member'] |
There was a problem hiding this comment.
From a very quick check, data['member'] doesn't seem to exist anymore so I ignored the code relating to it.
There was a problem hiding this comment.
data['member'] is present when messages are received via a gateway event
| member = @channel.server.member(data['author']['id'].to_i) | ||
|
|
||
| if member | ||
| member.update_data(data['member']) if data['member'] |
There was a problem hiding this comment.
data['member'] is present when messages are received via a gateway event
lib/discordrb/data/message.rb
Outdated
| @@ -390,5 +357,36 @@ def buttons | |||
|
|
|||
| results.flatten.compact | |||
| end | |||
|
|
|||
| # The user who sent this message message. Will be a {Member} most of the time, a {User} in the case | |||
| # that the user has left the server, or a {Recipient} if the message was sent in a private channel. | |||
lib/discordrb/data/message.rb
Outdated
| author = @channel.server.member(author_id) || @bot.user(author_id) | ||
| case author | ||
| when Member | ||
| author.update_data(@author_data) |
There was a problem hiding this comment.
Because we're handling this lazily now we should not update at this point in the lifecycle. There is no guarantee that our data is more up to date than the cache
There was a problem hiding this comment.
We may need to ensure that we're updating/creating the member during the MessageCreate event processing though
There was a problem hiding this comment.
Is this what ensure_user is for?
|
Thanks for the PR! Just some minor things to work through before we get it merged |
# Conflicts: # lib/discordrb/data/message.rb
lib/discordrb/data/message.rb
Outdated
| # directly because the bot may also send messages to the channel | ||
| Recipient.new(@bot.user(author_id), @channel, @bot) | ||
| else | ||
| author = @channel.server.member(author_id) || @bot.user(author_id) |
There was a problem hiding this comment.
Similarly, we should use ensure_member/ensure_user
There was a problem hiding this comment.
member is cached by default but made the other changes
Summary
Fixes #117. Calling
Message#authorwill still result in 'Unknown Member' being printed if the member does not exist (don't think there's a way to hide this? It is kinda annoying), but it won't hang instantiators ofMessagesuch asChannel#history.This is a bit rough right now but functional, will make a cleanup pass when I have more time.
Fixed
Message#authoras a method instead of an attribute