Image Size Parameter #147
Draft
Image Size Parameter #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanisSupraOmnia
force-pushed
the
feat/image-size-parameter
branch
from
d74c0b8
to
ab43823
Compare
|
I'm fine with size being a kwarg here, but for consistency's sake I wonder if we should keep it as an optional positional. I'd like some input |
swarley
added
enhancement
The RuboCop check should be invoked using bundler so that the correct RuboCop version is used, otherwise we'll get unexpected results. Also, We can re-enable the AuthorName check because the original behavior of the check that prompted it to be disabled has been changed upstream; first and last name are no longer required, anything of non-0 length is sufficient.
The basic image_url API methods now take a size param and I also added it to the user-facing methods that currently expose the image format parameter; this means there are some places where the size param is not available.
PanisSupraOmnia
force-pushed
the
feat/image-size-parameter
branch
from
ab43823
to
4e30c11
Compare
PanisSupraOmnia
force-pushed
the
feat/image-size-parameter
branch
from
92a597a
to
622fa1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #131.
This PR adds the ability to specify a size for the image returned for a variety of CDN endpoints. I also improved the Overcommit configuration since I happened to run into an issue with it while committing the changes for this PR; I realize these are unrelated changes so I can split them to a separate PR if you'd like.
Added
Fixed
AuthorNamecheck because the original behavior of the check that prompted it to be disabled has been changed upstream; first and last name are no longer required, anything of non-zero length is sufficient.