Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use retry-after response header if missing in the response body for 429 API bans #120

Merged
merged 1 commit into from Jan 14, 2022
Merged

fix: Use retry-after response header if missing in the response body for 429 API bans #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/discordrb/api.rb
View file
Open in desktop
Expand Up @@ -143,7 +143,7 @@ def request(key, major_parameter, type, *attributes)

unless mutex.locked?
response = JSON.parse(e.response)
wait_seconds = response['retry_after'].to_f
wait_seconds = response['retry_after'] ? response['retry_after'].to_f : e.response.headers[:retry_after].to_i
Discordrb::LOGGER.ratelimit("Locking RL mutex (key: #{key}) for #{wait_seconds} seconds due to Discord rate limiting")
trace("429 #{key.join(' ')}")

Expand Down