New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RLS/BLD: use native Apple Silicon macOS for arm64 wheels; remove universal2 #1990
Conversation
Up to @jorisvandenbossche to decide about these changes for the upcoming maintenance release version 2.0.3 described in #1742 I'm working on a separate PR for |
It's still showing the same warning / not actually running tests:
|
(I think it is also fine to directly target this PR to main, can still backport the eventual commit to 2.0.x if we want) |
a9a9693
to
ef99fe5
Compare
Switched to |
Pull Request Test Coverage Report for Build 7884170432Details
💛 - Coveralls |
ef99fe5
to
23aceba
Compare
Warnings all cleared up now, ready for final review. I should elaborate more on why to remove
which is cool, but there are individual wheels for each architecture, so pip should be able to fetch the correct built wheel for the host platform. But also be warned that I'm not a macOS user, so I don't have any direct experience with this stuff. |
Do you want me to test something here? I have access to both M1 and Intel Mac. |
@martinfleis My main curiosity is with |
That would pull |
Yes, certainly on board with that. In most other projects where I am involved in, we also dropped the universal wheels the last years (eg pandas, and also numpy did the same I see) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Use native Apple Silicon macOS runners (described here) to build arm64 wheels.
Also, remove
universal2
wheels, since I think it's fine to have separatex86_64
builds for macOS.