Draft of a governance doc #1822
Conversation
Adapted from rasterio's, which is adapted from NumPy's.
Pull Request Test Coverage Report for Build 5062325103
💛 - Coveralls |
There was a problem hiding this comment.
Thanks @sgillies for taking this initiative. A landmark in professionalizing Shapely!
I read through it and nothing stands out in particular. Do you have a specific section that needs extra attention?
One thought; when describing what shapely is, it might be good to mention GEOS, as shapely is largely an API around GEOS.
|
@caspervdw I was hoping that adapting Numpy's governance doc would be uncontroversial. And I find it to be both practical and philosophical. As to professionalization: I don't want to take it too far! I'd like Shapely to not depart too much from its punk and DIY roots 😄 |
|
Unrelated to this PR: it looks like we have some flaky tests. |
Yep the GEOS main branch often fails because we have lots of super strict tests. I think that’s a good thing but having the red X everywhere is not. |
|
@sgillies are you 👍 on merging this? |
There was a problem hiding this comment.
Thanks for getting this started! I am very supportive to describing our governance. And generally fine with adapting the NumPy governance documents.
One aspect I am wondering: do we want to say something about "commit rights" (who has those, how to get them, ...), or do we leave that detail to the practical day-to-day organization without being written out? (assuming this is not tied to being Steering Council member). Also the NumPy document doesn't mention this, and I can't directly find where this is described elsewhere for them (they do mention to have teams on their website, and list the "maintainers" members as one of the teams at https://numpy.org/teams/)
| substantive API changes must be posted to the mailing list in order to give the | ||
| broader community a chance to catch any problems and suggest improvements; we |
There was a problem hiding this comment.
This is probably a left-over from numpy, since we don't have a mailing list for shapely (unless we plan to create one?)
In the version we adapted for geopandas, we changes this section a bit to just mention that the GitHub issues/PRs would be left open for a bit longer "to provide greater opportunity for feedback": https://github.com/geopandas/governance/blob/main/Governance.md#consensus-based-decision-making-by-the-community
| [There is no funding today. Institutional partners are the companies that | ||
| employ contributors to, in part, work on Shapely. This section is about | ||
| defining "Institutional partner", not about enumerating them. We'll borrow from | ||
| Jupyter and NumPy.] |
There was a problem hiding this comment.
Is this intended to stay? (we could add a note that there is currently no funding, but then would clean it up a bit)
Adapted from rasterio's, which is adapted from NumPy's.
This is a follow up on something I wrote at the start of 2023: #1740 (comment).