Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for any MultiPolygons when constructing a MultiPolygon #1786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check for any MultiPolygons when constructing a MultiPolygon #1786

wants to merge 1 commit into from

Conversation

ianwilliamson
Copy link

Currently, the MultiPolygon constructor only validates the type of the first element of the polygons input. When a later element does not have the correct type, things silently fail.

jorisvandenbossche
jorisvandenbossche reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you add a test for it as well? (in shapely/tests/geometry/test_multipolygon.py, I think)

@jorisvandenbossche
Copy link
Member

Hey @ianwilliamson would you have time to add a small test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ianwilliamson @jorisvandenbossche