Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: update valgrind Dockerfile #1649

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .dockerignore
Expand Up @@ -5,8 +5,10 @@
!/*.py
!/*LICENSE*
!/setup.cfg
!/pygeos/**
!/pyproject.toml
!/shapely/**
!/src/**
!/tests/**

# Ignore unnecessary files inside allowed directories
# This should go after the allowed directories
Expand Down
8 changes: 4 additions & 4 deletions docker/Dockerfile.arm64
@@ -1,8 +1,8 @@
# This docker container is used for testing pygeos in ARM64 emulation mode.
# This docker container is used for testing shapely in ARM64 emulation mode.
# To build it:
# docker build . -f ./docker/Dockerfile.arm64 -t pygeos/arm64
# Then run the pygeos test suite:
# docker run --rm pygeos/arm64:latest python3 -m pytest -vv
# docker build . -f ./docker/Dockerfile.arm64 -t shapely/arm64
# Then run the shapely test suite:
# docker run --rm shapely/arm64:latest python3 -m pytest -vv

FROM --platform=linux/arm64/v8 arm64v8/ubuntu:20.04

Expand Down
8 changes: 4 additions & 4 deletions docker/Dockerfile.valgrind
@@ -1,7 +1,7 @@
# This docker is used for memory leak testing of pygeos. To use it, first build:
# docker build . -f ./docker/Dockerfile.valgrind -t pygeos/valgrind
# This docker is used for memory leak testing of shapely. To use it, first build:
# docker build . -f ./docker/Dockerfile.valgrind -t shapely/valgrind
# Then run the pytest suite with valgrind enabled:
# docker run --rm pygeos/valgrind:latest valgrind --show-leak-kinds=definite --log-file=/tmp/valgrind-output python -m pytest -vv --valgrind --valgrind-log=/tmp/valgrind-output > valgrind.log
# docker run --rm shapely/valgrind:latest valgrind --show-leak-kinds=definite --log-file=/tmp/valgrind-output python -m pytest -vv --valgrind --valgrind-log=/tmp/valgrind-output > valgrind.log


FROM python:3.9-slim-buster
Expand Down Expand Up @@ -29,5 +29,5 @@ RUN export GEOS_VERSION=3.10.3 && \

COPY . /code

# Build pygeos
# Build shapely
RUN python setup.py build_ext --inplace && python setup.py install