Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dev requirements to pyproject.toml #1564

Closed
wants to merge 2 commits into from
Closed

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Oct 10, 2022

Removes requirements-dev.txt file and consolidates those requirements as optional dependencies in pyproject.toml with the [dev] extra.

Also requires a newer version of Cython for Python 3.11, and specify minimum instead of specific versions for Cython and Descartes.

EwoutH and others added 2 commits October 10, 2022 10:06
Require newer version of Cython for Python 3.11, and specify minimum instead of specific versions for Cython and Descartes.
Removes requirements-dev.txt and consolidates those requirements as optional dependencies in pyproject.toml with the [dev] extra.
@jorisvandenbossche
Copy link
Member

FYI we might temporarily move away again from having the project details in pyproject.toml because it is still experimental in setuptools (and not supported everywhere, such as debian), see #1533. So I would keep this on hold until we made a decision there.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3217818103

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.582%

Totals Coverage Status
Change from base Build 3217626353: 0.0%
Covered Lines: 2145
Relevant Lines: 2536

💛 - Coveralls

@EwoutH
Copy link
Contributor Author

EwoutH commented Oct 10, 2022

In June they removed the experimental status for a lot of parts of the pyproject.toml configuration, including project metadata (see current docs).

It is been a few months since the implementation of PEP 621 support landed in setuptools (after a long period of feedback), and it seems now that support for project metadata in pyproject.toml has stabilised. Moreover the existing implementation is backed by a PEP, therefore it makes sense to consider this part of the feature stable.

@mwtoews
Copy link
Member

mwtoews commented Nov 15, 2022

Apologies @EwoutH as I've prepared a similar #1606

@mwtoews mwtoews closed this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants