Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing incorrect model parse when XGB buf starts with 'binff' or 'binfn' #2162

Merged
merged 8 commits into from Jun 15, 2022
Merged

Fixing incorrect model parse when XGB buf starts with 'binff' or 'binfn' #2162

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81da34e
remove lstrip(b'binf') from XGBTreeModelLoader
TheZL Sep 2, 2021
91e3b8c
Update _tree.py
TheZL Sep 2, 2021
c183e05
Update code to be more succinctly
TheZL Dec 30, 2021
6795f73
Merge branch 'master' into xgbmodel_buffer_lstrip_error_correction
lrjball Feb 28, 2022
f1318e3
Added test for buffer strip update
lrjball Feb 28, 2022
f1b328c
Merge pull request #1 from lrjball/xgbmodel_buffer_lstrip_error_corre…
TheZL Mar 1, 2022
0fd465d
Merge branch 'master' into xgbmodel_buffer_lstrip_error_correction
slundberg Mar 23, 2022
2cfa489
Merge branch 'master' into xgbmodel_buffer_lstrip_error_correction
slundberg Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion shap/explainers/_tree.py
View file
Open in desktop
Expand Up @@ -1414,7 +1414,10 @@ class XGBTreeModelLoader(object):
"""
def __init__(self, xgb_model):
# new in XGBoost 1.1, 'binf' is appended to the buffer
self.buf = xgb_model.save_raw().lstrip(b'binf')
self.buf = xgb_model.save_raw()
start_buf = self.buf[:4]
if start_buf == bytearray(b'binf'):
self.buf = self.buf[4:]
self.pos = 0

# load the model parameters
Expand Down