Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for React integration #110

Merged
merged 2 commits into from
May 17, 2022

Conversation

jameshibbard
Copy link
Contributor

Adds docs on React integration (as discussed here).

@jameshibbard jameshibbard changed the title Added React integration Added documentation for React integration Apr 28, 2022
@justin808 justin808 requested a review from tomdracz May 2, 2022 23:47
Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting. A couple suggestions!

Before starting, ensure that you have Yarn installed:

```shell
npm i -g yarn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf and yvm are other ways.

Let's say, "for example"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I updated the PR.

./bin/webpacker-dev-server
```

10. Hit: <http://localhost:3000/site/index>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using <URL> better? Do we need the <?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shortcut style for creating “automatic” links for URLs, which means you can show the text of the URL and also have it be a clickable link. See here.

Happy to remove if it's not needed.

Copy link
Collaborator

@tomdracz tomdracz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @jameshibbard

@tomdracz tomdracz merged commit 2f13aee into shakacode:master May 17, 2022
@jameshibbard jameshibbard deleted the react-docs branch May 17, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants