Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap update_files calls in conditionals #147

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Wrap update_files calls in conditionals #147

merged 5 commits into from
Jan 4, 2024

Conversation

Judahmeek
Copy link
Contributor

Should resolve #144

@cypress Cypress
Copy link

cypress bot commented Dec 15, 2023 •
edited

Passing run #106 ↗︎

0 10 0 0 Flakiness 0

Details:

Merge e32ef33 into 92ed2fd...
Project: cypress-on-rails Commit: 6fe3e63f58 ℹ️
Status: Passed Duration: 00:15 💡
Started: Jan 4, 2024 2:34 AM Ended: Jan 4, 2024 2:35 AM

Review all test suite changes for PR #147 ↗︎

@grantspeelman
Copy link
Collaborator

thanks @Judahmeek for picking this up 👍🏽

@grantspeelman grantspeelman merged commit bce4b18 into master Jan 4, 2024
4 checks passed
@grantspeelman grantspeelman deleted the judahmeek/conditional-wrap branch January 4, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhaledEmaraDev KhaledEmaraDev Awaiting requested review from KhaledEmaraDev

@grantspeelman grantspeelman Awaiting requested review from grantspeelman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cypress-on-rails gem Error: File unchanged! The supplied flag value not found! cypress/support/index.js
2 participants
@Judahmeek @grantspeelman