Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test Edge Chromium with Karma #3265

Merged
merged 2 commits into from Mar 30, 2021

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Mar 22, 2021

With this change it is possible to run the tests in Edge Chromium by default.

Karma needs to be updated to allow wildcard scoped packages to be used by default, see: karma-runner/karma#3659

Test results on macOS:

./build/test.py
[WARNING] Using default browsers: ['Chrome', 'Edge', 'Firefox', 'Safari']
[INFO] Generating Closure dependencies...
[INFO] Compiling the library (ui, release)...
[INFO] Running test (1 / 1, 0 failed so far)...
Chrome 89.0.4389.90 (Mac OS 10.15.7): Executed 2058 of 2096 (skipped 38) SUCCESS (7 mins 14.056 secs / 7 mins 4.732 secs)
Edge 89.0.774.54 (Mac OS 10.15.7): Executed 2011 of 2096 (skipped 85) SUCCESS (7 mins 12.33 secs / 7 mins 4.255 secs)
Firefox 86.0 (Mac OS 10.15): Executed 2011 of 2096 (skipped 85) SUCCESS (7 mins 18.377 secs / 7 mins 9.345 secs)
Safari 14.0.3 (Mac OS 10.15.7): Executed 2011 of 2096 (skipped 85) SUCCESS (7 mins 17.412 secs / 7 mins 6.846 secs)
TOTAL: 8091 SUCCESS
[INFO] Run complete
[INFO] Result (exit code): 0

@avelad
Copy link
Collaborator Author

avelad commented Mar 29, 2021

@michellezhuogg can you run the Shaka-bot?

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit e610806 into shaka-project:master Mar 30, 2021
@avelad avelad deleted the karma-edge branch March 31, 2021 06:46
@Ra-Won
Copy link

Ra-Won commented Mar 31, 2021

Sir I was willing to contribute to this project but am not able to set it up on my local environment and I was not able to find proper instructions about it. Can anyone guide me regarding this?

@avelad
Copy link
Collaborator Author

avelad commented Mar 31, 2021

@Ra-Won Please open a question type issue for this. Thank you.

@michellezhuogg
Copy link
Contributor

michellezhuogg commented Mar 31, 2021

@avelad, Sorry about that.

Hello @Ra-Won, to start, checkout our demo and tutorial page. You can see more details in the doc.
Btw, if you're applying for GSoC, let's discuss in our Google group if you have any further questions. We're mindful of posting on Github, since it may spam other developers and contributors. Thank you!

joeyparrish pushed a commit that referenced this pull request Apr 25, 2021
Backported to v2.5.x

Change-Id: I83f8384111e8e46ee559028ead55300f5c0f6736
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants