Update/types #144
Merged
Update/types #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sghall Hi, could you check please, merge and publish new version of package? Otherwise, it's incompatible with React 18 types. |
davidslaby
approved these changes
May 12, 2022
patrikliska
commented
May 12, 2022
| @@ -36,7 +36,7 @@ interface RCSComponent { | |||
| }; | |||
| } | |||
|
|
|||
| const isRCSComponent = (item: React.ReactNode): item is RCSComponent => { | |||
| const isRCSComponent = (item: React.ReactNode) => { | |||
There was a problem hiding this comment.
This is automatically typed
|
Also having issues with this, would love to see the new version published! |
|
Ditto! |
|
Hey 👋 I will take a look at this over the weekend. Apologies for the delay. |
|
@sghall any change of it getting merged? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In @types/react 18 there is error redwoodjs/redwood#5104 (comment)
@types/react needs to be updated in this library for proper behavior