Update types.ts GetEventData to match Slider.tsx #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of `GetEventData` in Slider.tsx contains a boolean which is not present in the types.ts file. Relevant snippet here: https://github.com/sghall/react-compound-slider/blob/2fff320a8476d4f2b03cd6cfb83e79e916b5592e/src/Slider/Slider.tsx#L352 I've left `isTouch` as optional so that it does not break existing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
react-compound-sliderdevs. Just a small update request to your types file so that it doesn't need to be overwritten if people want access toisTouch.Implementation of
GetEventDatain Slider.tsx contains a boolean which is not present in the types.ts file. Relevant snippet here:react-compound-slider/src/Slider/Slider.tsx
Line 352 in 2fff320
I've left
isTouchas optional so that it does not break existing functionality.