Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): set hard version of core to avoid issue with setoutput #42

Merged
merged 1 commit into from Oct 5, 2022

Conversation

ThibDujardin
Copy link
Contributor

No description provided.

@rlespinasse
Copy link
Member

what is the issue related to this?

@ThibDujardin
Copy link
Contributor Author

There is no issue related to this or I didn't found the one related to this.
This PR fix the "Operations testing" GA that fail on every build ( jest test )
It look like the Core library has made some change on the new version they made ( maybe it's a minor regression ) that make the output::.... no longer appear on the stdout

@rlespinasse
Copy link
Member

rlespinasse commented Oct 4, 2022

This will impact the slides on the interactions section as well

The PR seems to tell us that the legacy way still works.
I think we should continue to try fixing the test failure rather than hard-code the version.

@rlespinasse
Copy link
Member

GHSA-7r3h-m5j6-3q42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants