Add a container-level rename_all attribute to FromSql/ToSql
#952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this adds a few dependencies to keep the implementation concise. I, personally, subscribe to the “use as much of the crates.io ecosystem as you can possibly can” philosophy, but I can see how it may not be appropriate for the project. Still, that's what I did in the first version to gather feedback. Which dependency should be got rid of can perhaps be decided later. |
It works both with composite types' fields and enum variants, although arguably it will be the most useful for the latter as that's where the naming conventions between Rust and a typical PostgreSQL schema differ. Right now it supports the following casing styles: * `"camelCase"` * `"kebab-case"` * `"lowercase"` * `"PascalCase"` * `"SCREAMING-KEBAB-CASE"` * `"SCREAMING_SNAKE_CASE"` * `"snake_case"` * `"UPPERCASE"` mimicking Serde.
jakubadamw
force-pushed
the
934-container-attribute-rename-all
branch
from
4b6e704
to
f09d450
Compare
|
Since this is a library, I think it would be better to avoid introducing external dependencies to keep compile times down. @sfackler thoughts? The case conversion code in serde_derive might be helpful. |
|
@jakubadamw are you still working on this, would love this feature |
|
@JaydenElliott hey, not really, no. I'll be happy for someone else to take over this. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works both with composite types' fields and enum variants, although arguably it will be the most useful for the latter as that's where the naming conventions between Rust and a typical PostgreSQL schema differ.
Right now it supports the following casing styles, following serde:
"camelCase""kebab-case""lowercase""PascalCase""SCREAMING-KEBAB-CASE""SCREAMING_SNAKE_CASE""snake_case""UPPERCASE"Addresses #934.