Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add 'js' feature for wasm #1116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duarten
Copy link

@duarten duarten commented Mar 11, 2024

Enables the "js" feature of postgres-protocol, without which compiling postgres-types for wasm32-unknown-unknown would result in:

❯ cargo build --target wasm32-unknown-unknown -p postgres-types
   Compiling getrandom v0.2.12
error: the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature. For more information see: https://docs.rs/getrandom/#webassembly-support
   --> /Users/duarte.nunes/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.12/src/lib.rs:291:9
    |
291 | /         compile_error!("the wasm*-unknown-unknown targets are not supported by \
292 | |                         default, you may need to enable the \"js\" feature. \
293 | |                         For more information see: \
294 | |                         https://docs.rs/getrandom/#webassembly-support");
    | |________________________________________________________________________^

error[E0433]: failed to resolve: use of undeclared crate or module `imp`
   --> /Users/duarte.nunes/.cargo/registry/src/index.crates.io-6f17d22bba15001f/getrandom-0.2.12/src/lib.rs:347:9
    |
347 |         imp::getrandom_inner(dest)?;
    |         ^^^ use of undeclared crate or module `imp`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `getrandom` (lib) due to 2 previous errors

@duarten duarten force-pushed the postgres-types-js branch 3 times, most recently from 68bf415 to 6aaf77a Compare March 11, 2024 18:08
duarten added a commit to duarten/cornucopia that referenced this pull request Mar 11, 2024
Sets up some feature flags to allow compiling for wasm.

Due to limitation in rust-postgres, this only covers the async client.

Requires sfackler/rust-postgres#1116.
@duarten
Copy link
Author

duarten commented Mar 19, 2024

I think the CI failure is unrelated.

@duarten
Copy link
Author

duarten commented Apr 22, 2024

Ping.

Enables the "js" feature of postgres-protocol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant