Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating openssl-sys build error to inform the user about version incompatibilities. #2199

Closed
wants to merge 1 commit into from

Conversation

jmracek
Copy link

@jmracek jmracek commented Mar 5, 2024

I lost a couple of hours trying to figure out why openssl-sys wouldn't compile, even though I had a local system installation of OpenSSL. Turns out I was using 3.0.7, which is unsupported. When I downgrade to 3.0.0 and update my pkg-config path for the new installation, everything compiles correctly.

The current error message is too implicit, since the reader is left to assume that by simply installing OpenSSL that the error should be resolved. The new error message makes it explicit that only specific OpenSSL versions are supported.

…ntial version mismatches. This was previously hidden and not at all obvious
@sfackler
Copy link
Owner

sfackler commented Mar 5, 2024

Why do you think 3.0.7 isn't supported?

@jmracek
Copy link
Author

jmracek commented Mar 5, 2024

The comment immediately above the error message I'm modifying indicates which minor versions should be supported, and does not include 3.0.7. Given that I wasn't able to compile openssl-sys with 3.0.7 and a downgrade to 3.0.0 solved the problem, I assumed this to be the root cause and didn't look further into it. It's entirely possible I have some other error in my build setup causing the issue. I wanted to open the PR anyway and let other more knowledgeable folks guide the decision on what to do.

@jmracek
Copy link
Author

jmracek commented Mar 5, 2024

This comment, I meant

@sfackler
Copy link
Owner

sfackler commented Mar 5, 2024

That comment is out of date. All versions of OpenSSL from 1.0.1 and newer are supported.

@jmracek
Copy link
Author

jmracek commented Mar 5, 2024

Feel free to close the PR then, if it's not accurate. Unfortunately my error logs are lost to my bash history after building the downgraded OpenSSL version so I don't think I can reproduce the error anymore or give more details.

Thanks for your attention on this and sorry for the false positive!

@sfackler sfackler closed this Mar 5, 2024
@jmracek jmracek deleted the build-error-openssl-version branch March 5, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants