Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken relaxation #1762

Merged
merged 2 commits into from Dec 20, 2022
Merged

Commits on Dec 20, 2022

  1. Fix output buffer check introduced in sfackler#1733

    Sadly the condition used to relax output buffer checks that depended
    on the `num` parameter does not really hold so this change effectively
    reverts PR sfackler#1733.
    
    As clarified on the OpenSSL mailing list [0] and during integration tests
    the `num` parameter does not reflect the internal buffer cache size thus
    one needs to pessimistically assume that each call to `cipher_update`
    will need sufficient size to contain one additional block. Streaming
    ciphers are not affected by this revert.
    
    [0]: https://mta.openssl.org/pipermail/openssl-users/2022-December/015727.html
    wiktor-k committed Dec 20, 2022
    2
    Copy the full SHA
    71013f7 View commit details
    Browse the repository at this point in the history
  2. Expose Cipher::cipher_final_unchecked

    This mirrors the `Cipher::cipher_update_unchecked` API call for clients
    that want to manually track the state of internal OpenSSL cipher buffer
    size.
    wiktor-k committed Dec 20, 2022
    Copy the full SHA
    45e5dce View commit details
    Browse the repository at this point in the history