Deprecation notice about urllib3[secure] #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated with urllib3
18 tasks
|
Thanks! It looks like the package minimum version needs to be adjusted to 1.26.12 though. Prior to that, the incorrect behavior will occur. |
|
@william-silversmith While upgrading cannot hurt, you don't need to. We recommended removing that |
|
That sounds peachy then. For reference, it looks like urllib3 changed from supporting PyOpenSSL to using a python default module, which is why the flag is no longer necessary. |
|
@william-silversmith Saw that seung-lab/cloud-volume#552 got merged, is this one good to go as well? |
|
Thanks for the PR all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12)
urllib3/urllib3#2680
uremoved urllib3[secure] extra updated with urllib3