PR godot-rust#791 Address review feedback.

setzer22 · Oct 25, 2021 · 0038317 · 0038317
1 parent 76b73df
commit 0038317
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/gdnative-core/src/core_types/transform2d.rs b/gdnative-core/src/core_types/transform2d.rs
@@ -83,7 +83,7 @@ impl Transform2D {
         let mut inverted = *self;
 
         let det = self.basis_determinant();
-        // assert!(det != 0.0, "The determinant cannot be zero");
+        debug_assert!(det != 0.0, "The determinant cannot be zero");
         let idet = 1.0 / det;
 
         std::mem::swap(&mut inverted.x.x, &mut inverted.y.y);
@@ -164,7 +164,7 @@ impl Transform2D {
     /// Returns the transform's scale.
     #[inline]
     pub fn scale(&self) -> Vector2 {
-        let det_sign = f32::signum(self.basis_determinant());
+        let det_sign = self.basis_determinant().signum();
         Vector2::new(self.x.length(), det_sign * self.y.length())
     }