Fix clippy lint mismatched_target_os
#290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the deny-by-default clippy lint `mismatched_target_os`. We rename the `linux` cfg option to `free_unix`, which more accurately represents how it is used. The naming follows the cfg names chosen by the `winit` crate. the `wayland` cfg is slightly adjusted, to only be selected as the default if 1. wayland is enabled AND 2. either x11 is disabled, or the `sm-wayland-default` is selected Example clippy error message: ``` error: operating system used in target family position --> surfman/src/platform/unix/mod.rs:13:1 | 13 | #[cfg(linux)] | ^^^^^^-----^^ | | | help: try: `target_os = "linux"` | = help: did you mean `unix`? = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mismatched_target_os ``` Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
mrobinson
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the deny-by-default clippy lint
mismatched_target_os. We rename thelinuxcfg option tofree_unix, which more accurately represents how it is used. The naming follows the cfg names chosen by thewinitcrate.The
waylandcfg is slightly adjusted, to only be selected as the default if 1. wayland is enabled AND 2. either x11 is disabled, or thesm-wayland-defaultis selectedExample clippy error message: