-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added local directory listing feature. #32167
Open
Bobulous
wants to merge
14
commits into
servo:main
Choose a base branch
from
Bobulous:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,323
−5
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
692c539
Added local directory listing feature.
Bobulous 019c046
Grouped and sorted local directory listing. Added missing sub-directo…
Bobulous 3138aa2
Fixed problem where directory path does not end with forward-slash.
Bobulous 2b961d5
Addressed review feedback. Moved CSS into resources file. Replaced ta…
Bobulous cb6222c
Adjusted structure and styling of HTML for local directory listings. …
Bobulous 0217c52
Reworked unit tests to make use of temporary directory, instead of ac…
Bobulous a0d6cfb
Merge branch 'main' into main
Bobulous 2ddb8b1
Moved local directory listing feature behind a new Servo preference s…
Bobulous 7ed4eaf
Merge branch 'main' into main
Bobulous b719e19
Merge branch 'main' into main
Bobulous 7ef1c55
Merge branch 'main' into main
Bobulous d599958
Moved code and unit tests around based on review feedback. Further wo…
Bobulous b3470ed
Further work to satisfy review feedback, primarily related to unit te…
Bobulous f40e646
Merge branch 'main' into main
Bobulous File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to avoid further use of this crate, see #30150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #30150 suggests replacing the old "time" dependency with one of these alternatives:
From<std::time::SystemTime>
so it might be suitable, but I don't see "chrono" already listed in the main Cargo.toml file;Can you (or @mrobinson) tell me which is the preferred approach?