-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement XMLSerializer interface #23044
Conversation
Heads up! This PR modifies the following files:
|
I have filed servo/html5ever#368 about implementing the full XML serialization algorithm, which should allow the remaining tests to pass. That's a lot of work, though, and I won't prevent these changes from landing until it's done. Thanks! @bors-servo r+ |
📌 Commit c8ebb40 has been approved by |
☔ The latest upstream changes (presumably #22891) made this pull request unmergeable. Please resolve the merge conflicts. |
🔒 Merge conflict |
☔ The latest upstream changes (presumably #23051) made this pull request unmergeable. Please resolve the merge conflicts. |
Ack, sorry for not noticing this was ready to merge. |
@bors-servo delegate+ |
✌️ @georgeroman can now approve this pull request |
@bors-servo r=jdm |
📌 Commit c6433ef has been approved by |
Implement XMLSerializer interface <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22997 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23044) <!-- Reviewable:end -->
💔 Test failed - status-taskcluster |
@bors-servo retry
|
Implement XMLSerializer interface <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22997 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23044) <!-- Reviewable:end -->
💔 Test failed - mac-rel-wpt2 |
@bors-servo retry |
💣 Failed to start rebuilding: |
Implement XMLSerializer interface <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22997 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23044) <!-- Reviewable:end -->
☀️ Test successful - android-mac, arm32, arm64, linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, magicleap, status-taskcluster |
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is