Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document SyntaxViolation variants, remove bare URLs #924

Merged
merged 2 commits into from Apr 12, 2024

Conversation

aatifsyed
Copy link
Contributor

Fix these errors running cargo doc:

warning: this URL is not a hyperlink
  --> url/src/quirks.rs:68:5
   |
68 | /// https://url.spec.whatwg.org/#dom-url-domaintounicode
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://url.spec.whatwg.org/#dom-url-domaintounicode>`
   |
   = note: bare URLs are not automatically turned into clickable links
   = note: `#[warn(rustdoc::bare_urls)]` on by default

And have SyntaxViolation describe its variants in rustdocs

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@fd042e0). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage        ?   81.91%           
=======================================
  Files           ?       20           
  Lines           ?     3549           
  Branches        ?        0           
=======================================
  Hits            ?     2907           
  Misses          ?      642           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valenting valenting added this pull request to the merge queue Apr 12, 2024
Merged via the queue into servo:main with commit 8b8431b Apr 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants