Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement idna on top of ICU4X #923

Merged
merged 40 commits into from
Jun 3, 2024
Merged

Reimplement idna on top of ICU4X #923

merged 40 commits into from
Jun 3, 2024

Commits on Mar 20, 2024

  1. Reimplement idna on top of ICU4X

    @hsivonen
    hsivonen committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a8977a8 View commit details
    Browse the repository at this point in the history

  2. Add an even faster lower-case ASCII letter path to avoid regressing p… 

    …erformance
    @hsivonen
    hsivonen committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    09765af View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Comments and verify_dns_length tweak

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7e929ce View commit details
    Browse the repository at this point in the history

  2. Parametrize internal vs. external Punycode caller; restore external A… 

    …PI behavior
    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    f413387 View commit details
    Browse the repository at this point in the history

  3. Add bench for to_ascii on an already-Punycode name

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    71c03b9 View commit details
    Browse the repository at this point in the history

  4. Avoid re-encoding Punycode when possible

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9af00cb View commit details
    Browse the repository at this point in the history

  5. Pass through the input slice in many more cases

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    dc8f301 View commit details
    Browse the repository at this point in the history

  6. Add testing for the simultaneous mode

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    41e0192 View commit details
    Browse the repository at this point in the history

  7. Omit the invalid domain character check on the url side

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    41f2107 View commit details
    Browse the repository at this point in the history

  8. Document that Punycode labels must result in non-ASCII

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4d7d41a View commit details
    Browse the repository at this point in the history

  9. Rename files called uts46.rs to deprecated.rs

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    98ca752 View commit details
    Browse the repository at this point in the history

  10. Rename uts46bis to uts46

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4bbabe9 View commit details
    Browse the repository at this point in the history

  11. Tweak docs

    @hsivonen
    hsivonen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7dc0082 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Avoid useless copying and useless UTF-8 decode

    @hsivonen
    hsivonen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f8eb96e View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Use inline(never) to optimize binary size

    @hsivonen
    hsivonen committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    eb6e3d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Split CheckHyphens into a separate concern form the ASCII deny list

    @hsivonen
    hsivonen committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ce3d4d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Make the ASCII deny list customizable

    @hsivonen
    hsivonen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    6672161 View commit details
    Browse the repository at this point in the history

  2. Better docs and top-level functions

    @hsivonen
    hsivonen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    90fe4b3 View commit details
    Browse the repository at this point in the history

  3. Parameter for VerifyDNSLength

    @hsivonen
    hsivonen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    50381ff View commit details
    Browse the repository at this point in the history

  4. Restore support for transitional processing to minimize breakage

    @hsivonen
    hsivonen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8268c5a View commit details
    Browse the repository at this point in the history

  5. In the deprecated API, use empty deny list with use_std3_ascii_rules=… 

    …false
    @hsivonen
    hsivonen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    999bef4 View commit details
    Browse the repository at this point in the history

  6. Tweak docs

    @hsivonen
    hsivonen committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b277c85 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Docs, rename AsciiDenyList::WHATWG to ::URL, tweak top-level functions

    @hsivonen
    hsivonen committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    980348c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Use idna crate top-level function in the url crate to dogfood the top… 

    …-level function
    @hsivonen
    hsivonen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4efd589 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Add an Usage section to the README

    @hsivonen
    hsivonen committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    da6cf50 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Add an early return to map_transitional for readability

    @hsivonen
    hsivonen committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d938024 View commit details
    Browse the repository at this point in the history

  2. Document internal vs. external Punycode caller differences

    @hsivonen
    hsivonen committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    679edb9 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Per discussion with Valentin, revert deprecated API to the old behavi… 

    …or that does not check hyphens in positions 3 and 4
    @hsivonen
    hsivonen committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4f605c9 View commit details
    Browse the repository at this point in the history

  2. Add comments about not fixing deprecated API

    @hsivonen
    hsivonen committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bbf4308 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into icu4x

    @hsivonen
    hsivonen committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e842dae View commit details
    Browse the repository at this point in the history

  4. Add a comment explaining FailFast in deprecated.rs

    @hsivonen
    hsivonen committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6690c49 View commit details
    Browse the repository at this point in the history

  5. For future-proofing, add compiled_data cargo feature (currently alway… 

    …s required)

Since other changes in this changeset require a semver break anyway, this
change takes a semver break in the case of `default-features = false` in
order to avoid a future semver break if in the future a need to add a
bring-your-own-data (using `icu_provider`) constructor for `Uts46`
shows up.
    @hsivonen
    hsivonen committed May 3, 2024
    Configuration menu
    Copy the full SHA
    38cedad View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Remove remark about spec violation by making root dot permissibility … 

    …configurable
    @hsivonen
    hsivonen committed May 20, 2024
    Configuration menu
    Copy the full SHA
    52137e7 View commit details
    Browse the repository at this point in the history

  2. Clarify README about IDNA 2003/2008

    @hsivonen
    hsivonen committed May 20, 2024
    Configuration menu
    Copy the full SHA
    081f44b View commit details
    Browse the repository at this point in the history

  3. Add a historical remark to the README

    @hsivonen
    hsivonen committed May 20, 2024
    Configuration menu
    Copy the full SHA
    aaa7a40 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @hsivonen
    hsivonen committed May 20, 2024
    Configuration menu
    Copy the full SHA
    8b03034 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Depend on crates.io versions of icu_normalizer and icu_properties

    @hsivonen
    hsivonen committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c8a4bd3 View commit details
    Browse the repository at this point in the history

  2. Address clippy lints

    @hsivonen
    hsivonen committed May 23, 2024
    Configuration menu
    Copy the full SHA
    be3db8e View commit details
    Browse the repository at this point in the history

  3. Update versions

    @hsivonen
    hsivonen committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6020673 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Increment dependency versions

    @hsivonen
    hsivonen committed May 29, 2024
    Configuration menu
    Copy the full SHA
    245c514 View commit details
    Browse the repository at this point in the history