Non-special URLs can have their paths erased #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valenting
approved these changes
Apr 4, 2024
valenting
requested changes
Apr 4, 2024
url/src/lib.rs
Outdated
| @@ -146,9 +146,7 @@ pub use form_urlencoded; | |||
| extern crate serde; | |||
|
|
|||
| use crate::host::HostInternal; | |||
| use crate::parser::{ | |||
| to_u32, Context, Parser, SchemeType, PATH_SEGMENT, SPECIAL_PATH_SEGMENT, USERINFO, | |||
There was a problem hiding this comment.
Don't remove SPECIAL_PATH_SEGMENT from here please.
valenting
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bug 1874117 with reviewer @valenting
Sorry, I accidentally closed the first PR