perf(punycode): avoid double allocation in decode_to_string #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
=======================================
Coverage 81.70% 81.70%
=======================================
Files 20 20
Lines 3547 3547
=======================================
Hits 2898 2898
Misses 649 649 ☔ View full report in Codecov by Sentry. |
valenting
approved these changes
Jan 9, 2024
valenting
reviewed
Jan 9, 2024
| #[inline] | ||
| pub fn decode_to_string(input: &str) -> Option<String> { | ||
| decode(input).map(|chars| chars.into_iter().collect()) | ||
| Some(Decoder::default().decode(input).ok()?.collect()) |
There was a problem hiding this comment.
Could you maybe add a unit test that exercises this method?
There was a problem hiding this comment.
sure, will do that at the evening
There was a problem hiding this comment.
it is now being tested together with encode_str and decode
valenting
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
while indeed
decode_to_stringis a nice ergonomics addition, the fact of being a wrapper over thedecoderesults in an intermediateVec.Since the implementation of it can be the same as
decodeand it's quite straightforward, maybe we could get rid of double alloc cheaply