Fix multiple issues on wasm32, and runs url tests in CI #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
=======================================
Coverage ? 81.88%
=======================================
Files ? 20
Lines ? 3545
Branches ? 0
=======================================
Hits ? 2903
Misses ? 642
Partials ? 0 ☔ View full report in Codecov by Sentry. |
micolous
changed the title
|
Any updates? |
* remove `Url::socket_addrs` on wasm32-unknown-unknown (it won't work, those platform API calls are not supported) * disable unit tests which won't work on wasm32-unknown-unknown * run tests in `wasm_bindgen_test` on wasm32-unknown-unknown * remove `panic::catch_unwind` from wpt tests, as that conflicts with wasm-bindgen's panic handler * run the tests in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple issues on
wasm32-unknown-unknown:Url::socket_addrs()onwasm32-unknown-unknown. That function will never work – those platform API calls are not supported.wasm32-unknown-unknown.wasm_bindgen_testonwasm32-unknown-unknown.panic::catch_unwindfrom wpt tests, as that conflicts with wasm-bindgen-test's panic handler.urltests onwasm32-unknown-unknownin CI.